Document dynamic CI container image tag#39995
Closed
karlhorky wants to merge 1 commit intomicrosoft:mainfrom
Closed
Document dynamic CI container image tag#39995karlhorky wants to merge 1 commit intomicrosoft:mainfrom
karlhorky wants to merge 1 commit intomicrosoft:mainfrom
Conversation
karlhorky
force-pushed
the
docs/dynamic-container-version-ci-v2
branch
2 times, most recently
from
785ce44 to
145f4e8
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Adds documentation to the CI guide showing how to dynamically derive the Playwright Docker image tag from the project lockfile, preventing the workflow’s container image from drifting during Playwright upgrades.
Changes:
- Add a new “Via Containers (dynamic)” subsection for JS.
- Provide a
lockparse-based script to resolve the installed@playwright/testversion from common lockfiles. - Show a two-job GitHub Actions pattern that passes the resolved version into
jobs.<job>.container.image.
karlhorky
force-pushed
the
docs/dynamic-container-version-ci-v2
branch
7 times, most recently
from
73ace88 to
173f509
Compare
karlhorky
force-pushed
the
docs/dynamic-container-version-ci-v2
branch
from
173f509 to
265221a
Compare
This was referenced Apr 1, 2026
Skn0tt
reviewed
Apr 2, 2026
Member
Skn0tt
left a comment
Skn0tt
left a comment
There was a problem hiding this comment.
I like it! I Don't want to create yet another section in this doc though, do you think you can weave it into the existing JS example?
Member
|
The issue was closed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #39988
The CI docs hardcode the Playwright Docker image tag in workflow YAML, so it can drift from the installed Playwright version during upgrades.
This adds a short
Via Containers (dynamic)subsection with:package-lock.jsonversion="$(...)"lines for Yarn Berry, pnpm, and BunThis keeps the example short while covering the lockfile direction from #37637.